[Flashinfer][gpt-oss] Support FP8-qkv Flashinfer TRTLLM Sinks Attention#25674
Merged
mgoin merged 3 commits intovllm-project:mainfrom Oct 9, 2025
Merged
Conversation
63d414b to
ac1611c
Compare
|
This pull request has merge conflicts that must be resolved before it can be |
ac1611c to
8d6c871
Compare
8d6c871 to
9a53778
Compare
Contributor
|
@elvischenv Please fix the conflict. thanks! |
9a53778 to
8bfb46f
Compare
Signed-off-by: elvischenv <219235043+elvischenv@users.noreply.github.com>
Signed-off-by: elvischenv <219235043+elvischenv@users.noreply.github.com>
8bfb46f to
868f3de
Compare
mgoin
approved these changes
Oct 9, 2025
Dhruvilbhatt
pushed a commit
to Dhruvilbhatt/vllm
that referenced
this pull request
Oct 14, 2025
…on (vllm-project#25674) Signed-off-by: elvischenv <219235043+elvischenv@users.noreply.github.com> Signed-off-by: Dhruvil Bhatt <bhattdbh@amazon.com>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
…on (vllm-project#25674) Signed-off-by: elvischenv <219235043+elvischenv@users.noreply.github.com>
alhridoy
pushed a commit
to alhridoy/vllm
that referenced
this pull request
Oct 24, 2025
…on (vllm-project#25674) Signed-off-by: elvischenv <219235043+elvischenv@users.noreply.github.com>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
…on (vllm-project#25674) Signed-off-by: elvischenv <219235043+elvischenv@users.noreply.github.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
…on (vllm-project#25674) Signed-off-by: elvischenv <219235043+elvischenv@users.noreply.github.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
…on (vllm-project#25674) Signed-off-by: elvischenv <219235043+elvischenv@users.noreply.github.com>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
…on (vllm-project#25674) Signed-off-by: elvischenv <219235043+elvischenv@users.noreply.github.com>
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Support FP8-qkv Flashinfer TRTLLM sinks attention.
Note: require flashinfer v0.4.0rc4(updating in #26326)
flashinfer-ai/flashinfer#1758
Test Plan && Test Result
Kernel unit test:
tests/kernels/attention/test_flashinfer_trtllm_attention.pyE2E accuracy:
kv_cache_dtype=fp8
kv_cache_dtype=auto
E2E perf:
kv_cache_dtype=fp8, 6.9% perf gain
kv_cache_dtype=auto
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.