Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add ROCm Docker Build #2886

Merged
merged 31 commits into from
Mar 18, 2024
Merged

CI: Add ROCm Docker Build #2886

merged 31 commits into from
Mar 18, 2024

Conversation

simon-mo
Copy link
Collaborator

@simon-mo simon-mo commented Feb 15, 2024

This PR adds Buildkite CI for AMD build that test the compilation and running a simple model using api server.

It reverted #3376 because it doesn't compile on AMD. (I will leave a message to the original PR after merge)

Another known issue is that our structured generation library doesn't work on AMD for some reason. See #3280.

But I think this PR has high priority for future build (CMake) and catching compatibility issue.

@simon-mo
Copy link
Collaborator Author

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this file reverted?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I just saw the PR description. I believe this can be easily fixed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simon-mo Do you mind if I directly push a change to fix the kernel compilation error?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go ahead!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh just created a new PR #3470 to get reviewed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged #3470 Can you please rebase the PR with the current main branch?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's merge it once it passes the CI?

@simon-mo simon-mo enabled auto-merge (squash) March 18, 2024 19:17
@simon-mo simon-mo merged commit 8c654c0 into vllm-project:main Mar 18, 2024
31 checks passed
Temirulan pushed a commit to Temirulan/vllm-whisper that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants