Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Misc] Improve organization of utility and test code #5004

Closed
wants to merge 11 commits into from
Closed

[Misc] Improve organization of utility and test code #5004

wants to merge 11 commits into from

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented May 23, 2024 •
edited
Loading

This PR refactors some of the utilities and tests to improve code organization.

Edit: This PR has been split into smaller parts so that it is easier to review:

It will be closed once every component has been merged.

@DarkLight1337 DarkLight1337 changed the title [Misc] Improve organization of test code [Misc] Improve organization of utility and test code. May 23, 2024
@DarkLight1337 DarkLight1337 changed the title [Misc] Improve organization of utility and test code. [Misc] Improve organization of utility and test code May 23, 2024
@DarkLight1337 DarkLight1337 marked this pull request as draft May 23, 2024 09:39
@DarkLight1337 DarkLight1337 marked this pull request as ready for review May 24, 2024 02:04
@DarkLight1337 DarkLight1337 mentioned this pull request May 24, 2024
Merged
@DarkLight1337 DarkLight1337 marked this pull request as draft May 29, 2024 09:17
This was referenced May 29, 2024
Merged
Merged
Merged
Merged
Merged
@DarkLight1337
Copy link
Member Author

Closing as all components have been completed.

@DarkLight1337 DarkLight1337 deleted the refactor-tests branch June 14, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertgshaw2-neuralmagic robertgshaw2-neuralmagic Awaiting requested review from robertgshaw2-neuralmagic robertgshaw2-neuralmagic will be requested when the pull request is marked ready for review robertgshaw2-neuralmagic is a code owner

@simon-mo simon-mo Awaiting requested review from simon-mo simon-mo will be requested when the pull request is marked ready for review simon-mo is a code owner

@njhill njhill Awaiting requested review from njhill njhill will be requested when the pull request is marked ready for review njhill is a code owner

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon will be requested when the pull request is marked ready for review WoosukKwon is a code owner

@zhuohan123 zhuohan123 Awaiting requested review from zhuohan123 zhuohan123 will be requested when the pull request is marked ready for review zhuohan123 is a code owner

@youkaichao youkaichao Awaiting requested review from youkaichao youkaichao will be requested when the pull request is marked ready for review youkaichao is a code owner

@alexm-neuralmagic alexm-neuralmagic Awaiting requested review from alexm-neuralmagic alexm-neuralmagic will be requested when the pull request is marked ready for review alexm-neuralmagic is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac will be requested when the pull request is marked ready for review comaniac is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DarkLight1337