Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hardware][AMD][CI/Build][Doc] Upgrade to ROCm 6.1, Dockerfile improvements, test fixes #5422

Merged
merged 24 commits into from
Jun 25, 2024
Merged

[Hardware][AMD][CI/Build][Doc] Upgrade to ROCm 6.1, Dockerfile improvements, test fixes #5422

merged 24 commits into from
Jun 25, 2024

Commits on Jun 25, 2024

  1. Add ROCm tuned num_threads and partition_size for pagedattn

    @mawong-amd
    mawong-amd committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    32b9f67 View commit details
    Browse the repository at this point in the history

  2. Use PYTORCH_ROCM_ARCH env variable to set target list

    @mawong-amd
    mawong-amd committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    c3d3671 View commit details
    Browse the repository at this point in the history

  3. Upgrade Dockerfile to ROCm6.1 properly and improve logic, build FA an… 

    …d Triton in separate stages
    @mawong-amd
    mawong-amd committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    1b3b2a7 View commit details
    Browse the repository at this point in the history

  4. ROCm 6.1.2, reorder dependency installation for vLLM concurrent build

    @mawong-amd
    mawong-amd committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    a4679ed View commit details
    Browse the repository at this point in the history

  5. Standardize use of PyTorch 2.3.0 on ROCm 6.x

    @mawong-amd
    mawong-amd committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    e5a3428 View commit details
    Browse the repository at this point in the history

  6. Ensure use of docker buildkit for AMD container

    @mawong-amd
    mawong-amd committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    454cb21 View commit details
    Browse the repository at this point in the history

  7. Use nightly torch for ROCm 6.1, relax req to torch version >= 2.3.0

    @mawong-amd
    mawong-amd committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    84fe59d View commit details
    Browse the repository at this point in the history

  8. Fix up rebase errors, upgrade to torch 2.4.0, install amdsmi

    @mawong-amd
    mawong-amd committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    50b909b View commit details
    Browse the repository at this point in the history

  9. Fix test_cuda_device_count_stateless on ROCm

    @mawong-amd
    mawong-amd committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    ef1e4cb View commit details
    Browse the repository at this point in the history

  10. Use OpenAI triton instead of ROCm

    @mawong-amd
    mawong-amd committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    3bb3875 View commit details
    Browse the repository at this point in the history

  11. Revert ray workdir init from vllm-project#5100

    @mawong-amd
    mawong-amd committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    90ab818 View commit details
    Browse the repository at this point in the history

  12. Use 240612 torch wheels, prevent runtime interference

    @mawong-amd
    mawong-amd committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    ba8130c View commit details
    Browse the repository at this point in the history

  13. Use CUDA_VISIBLE_DEVICES for ROCm tests

    @mawong-amd
    mawong-amd committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    2583953 View commit details
    Browse the repository at this point in the history

  14. Reviewer comments on Dockerfile

    @mawong-amd
    mawong-amd committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    4786050 View commit details
    Browse the repository at this point in the history

  15. Unify setting CUDA_VISIBLE_DEVICES and carrying it over to HIP_VISIBL… 

    …E_DEVICES on ROCm
    @mawong-amd
    mawong-amd committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    85cb7d0 View commit details
    Browse the repository at this point in the history

  16. Remove sccache so it does not shadow ccache

    @mawong-amd
    mawong-amd committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    ae9e82c View commit details
    Browse the repository at this point in the history

  17. Propagate CUDA_VISIBLE_DEVICES to HIP_VISIBLE_DEVICES if set before init

    @mawong-amd
    mawong-amd committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    e49260d View commit details
    Browse the repository at this point in the history

  18. Revert "Add ROCm tuned num_threads and partition_size for pagedattn" 

    This reverts commit 75d5583ff83b5ef98ab97455ea0e7b5b8867331f.
    @mawong-amd
    mawong-amd committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    554cff1 View commit details
    Browse the repository at this point in the history

  19. Revert "Ensure use of docker buildkit for AMD container" 

    This reverts commit 834d006bdc3fa5ab1a5cb6d73bf55f44bd3de8d2.
    @mawong-amd
    mawong-amd committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    32fb98b View commit details
    Browse the repository at this point in the history

  20. Fix HIP_VISIBLE_DEVICE updating in device_count_stateless

    @mawong-amd
    mawong-amd committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    e239bfc View commit details
    Browse the repository at this point in the history

  21. Robustify cuda_device_count_stateless logic on ROCm

    @mawong-amd
    mawong-amd committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    016a553 View commit details
    Browse the repository at this point in the history

  22. Skip xfail tests on ROCm to conserve CI resources

    @mawong-amd
    mawong-amd committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    40c33ec View commit details
    Browse the repository at this point in the history

  23. Address reviewer comments 

    Revert "Skip xfail tests on ROCm to conserve CI resources"

This reverts commit 01fa95f7862ea52b19d96c16a5e1f7752cff3577.
    @mawong-amd
    mawong-amd committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    c293b3a View commit details
    Browse the repository at this point in the history

  24. Add amdsmi support for GPU memory check

    @mawong-amd
    mawong-amd committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    353c0b2 View commit details
    Browse the repository at this point in the history