-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI/Build][REDO] Add is_quant_method_supported to control quantization test configurations #5466
Merged
simon-mo
merged 11 commits into
vllm-project:main
from
neuralmagic:refactor-checking-supported-quant-method
Jun 13, 2024
Merged
[CI/Build][REDO] Add is_quant_method_supported to control quantization test configurations #5466
simon-mo
merged 11 commits into
vllm-project:main
from
neuralmagic:refactor-checking-supported-quant-method
Jun 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-mo
approved these changes
Jun 12, 2024
robertgshaw2-neuralmagic
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Jun 16, 2024
…n test configurations (vllm-project#5466)
joerunde
pushed a commit
to joerunde/vllm
that referenced
this pull request
Jun 17, 2024
…n test configurations (vllm-project#5466)
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jun 27, 2024
…n test configurations (vllm-project#5466)
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 8, 2024
…n test configurations (vllm-project#5466)
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 24, 2024
…n test configurations (vllm-project#5466)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were many separate uses of checking CUDA compute capability in order to run quantization tests, so it is best practice to have one function to be the source-of-truth to check support.
Instead of each quantization test having duplicated code such as:
It can be replaced with: