-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pp threads #5929
Open
Anirudhaagrawal
wants to merge
16
commits into
vllm-project:main
Choose a base branch
from
SolitaryThinker:pp-threads
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Pp threads #5929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 93fbcc8 Author: Muralidhar Andoorveedu <[email protected]> Date: Sun May 26 06:19:22 2024 +0000 Fix kv cache load Signed-off-by: Muralidhar Andoorveedu <[email protected]> commit bfc1420 Author: Muralidhar Andoorveedu <[email protected]> Date: Sun May 26 06:11:37 2024 +0000 Test eager mode for now Signed-off-by: Muralidhar Andoorveedu <[email protected]> commit 51a5ae3 Author: Muralidhar Andoorveedu <[email protected]> Date: Thu May 23 00:06:16 2024 +0000 Missed line rebasing, adding back Signed-off-by: Muralidhar Andoorveedu <[email protected]> commit aa15338 Author: Muralidhar Andoorveedu <[email protected]> Date: Wed May 22 21:22:26 2024 +0000 Format Signed-off-by: Muralidhar Andoorveedu <[email protected]> commit 69166a1 Author: Muralidhar Andoorveedu <[email protected]> Date: Wed May 22 21:05:43 2024 +0000 Add virtual_engine parameter to execute_model method Signed-off-by: Muralidhar Andoorveedu <[email protected]> commit 2cd0efa Author: Muralidhar Andoorveedu <[email protected]> Date: Wed May 22 21:02:26 2024 +0000 Small typo Signed-off-by: Muralidhar Andoorveedu <[email protected]> commit eb204b1 Author: Muralidhar Andoorveedu <[email protected]> Date: Wed May 22 19:26:53 2024 +0000 chore: Update test-pipeline.yaml and model runner files Signed-off-by: Muralidhar Andoorveedu <[email protected]> commit 67f2430 Author: Muralidhar Andoorveedu <[email protected]> Date: Wed May 22 18:22:23 2024 +0000 Add scheduler num blocks guard Signed-off-by: Muralidhar Andoorveedu <[email protected]> commit 8ecd41b Author: Muralidhar Andoorveedu <[email protected]> Date: Wed May 22 17:22:24 2024 +0000 PP Test changes Signed-off-by: Muralidhar Andoorveedu <[email protected]> commit cc9735d Author: Muralidhar Andoorveedu <[email protected]> Date: Wed May 22 16:53:59 2024 +0000 Add guard for cache config Signed-off-by: Muralidhar Andoorveedu <[email protected]> commit b9d523d Author: Muralidhar Andoorveedu <[email protected]> Date: Wed May 22 16:27:16 2024 +0000 Update test_preemption Signed-off-by: Muralidhar Andoorveedu <[email protected]> commit 2152141 Author: Muralidhar Andoorveedu <[email protected]> Date: Wed May 22 08:37:50 2024 +0000 Add PP PyNCCL to make up for new PyTorch version Signed-off-by: Muralidhar Andoorveedu <[email protected]> commit 9d5ea3e Author: Muralidhar Andoorveedu <[email protected]> Date: Wed May 22 07:03:23 2024 +0000 Formatting Signed-off-by: Muralidhar Andoorveedu <[email protected]> commit c62b294 Author: Muralidhar Andoorveedu <[email protected]> Date: Wed May 22 02:35:16 2024 +0000 Squashed commit of the following: commit 921bb1a014d435089db634fea9451b8c9f945459 Author: Muralidhar Andoorveedu <[email protected]> Date: Wed May 22 02:28:47 2024 +0000 Add back driver worker arg Signed-off-by: Muralidhar Andoorveedu <[email protected]> commit 39c6019865192737ce3cd09c50d13db2a32e1ca5 Author: Muralidhar Andoorveedu <[email protected]> Date: Thu May 9 00:22:12 2024 +0000 Test fix Signed-off-by: Muralidhar Andoorveedu <[email protected]> commit b60f7ea8779ae5e35c68868f327569df2167b88f Author: Muralidhar Andoorveedu <[email protected]> Date: Wed May 8 04:54:52 2024 +0000 Refactoring and test fixes Signed-off-by: Muralidhar Andoorveedu <[email protected]> commit 7e993601f47e68afe31b30ac66f9252956ce58c9 Author: Muralidhar Andoorveedu <[email protected]> Date: Wed May 8 00:22:33 2024 +0000 Formatting Signed-off-by: Muralidhar Andoorveedu <[email protected]> commit 2091dd91d06070d1db0f82670e82120d5f7ad5f4 Author: Muralidhar Andoorveedu <[email protected]> Date: Tue May 7 21:48:21 2024 +0000 Basic PP tests Signed-off-by: Muralidhar Andoorveedu <[email protected]> commit 016e25664434dc6f63eed9526e5982048757d7a2 Author: Muralidhar Andoorveedu <[email protected]> Date: Tue May 7 20:40:54 2024 +0000 Formatting Signed-off-by: Muralidhar Andoorveedu <[email protected]> commit ee86cd204666eab815e42be703c5f434c41af255 Author: Muralidhar Andoorveedu <[email protected]> Date: Tue May 7 20:40:36 2024 +0000 Fix condition for PP support Signed-off-by: Muralidhar Andoorveedu <[email protected]> commit df9b0c45cee14395b2b2dff9c4e3343ab2a019a1 Author: Muralidhar Andoorveedu <[email protected]> Date: Tue May 7 18:16:55 2024 +0000 Fix hangs Signed-off-by: Muralidhar Andoorveedu <[email protected]> commit 2180531ed5592d49cfa7492cebc92269693094ee Author: Muralidhar Andoorveedu <[email protected]> Date: Tue May 7 04:01:29 2024 +0000 Fix typo Signed-off-by: Muralidhar Andoorveedu <[email protected]> commit a17fcfe02c820f7b83bdcc3704059fcb35a231b8 Author: Muralidhar Andoorveedu <[email protected]> Date: Tue May 7 01:50:24 2024 +0000 Assert out model architectures that are unsupported Signed-off-by: Muralidhar Andoorveedu <[email protected]> commit f784fda224144f82065c19c643912390ab29b849 Author: Muralidhar Andoorveedu <[email protected]> Date: Tue May 7 01:17:33 2024 +0000 More test fixes Signed-off-by: Muralidhar Andoorveedu <[email protected]> commit 04b5fe903ac4598b5337d457afd684426e384690 Author: Muralidhar Andoorveedu <[email protected]> Date: Sun May 5 17:28:42 2024 +0000 Change condition for prepare_input_tensors to broadcast Signed-off-by: Muralidhar Andoorveedu <[email protected]> commit 526bade032dbeba73f6523009701f8a5f4b222f9 Author: Muralidhar Andoorveedu <[email protected]> Date: Sun May 5 17:14:48 2024 +0000 Fixed bug with TP + PP execution Signed-off-by: Muralidhar Andoorveedu <[email protected]> commit 9d698fa Author: Muralidhar Andoorveedu <[email protected]> Date: Thu May 2 18:38:41 2024 +0000 Format and test changes Signed-off-by: Muralidhar Andoorveedu <[email protected]> commit 16a5aac Author: Muralidhar Andoorveedu <[email protected]> Date: Thu May 2 18:30:46 2024 +0000 Format and test changes Signed-off-by: Muralidhar Andoorveedu <[email protected]> commit 65a5300 Author: Muralidhar Andoorveedu <[email protected]> Date: Wed May 1 06:42:13 2024 +0000 Simplify weight loading logic Signed-off-by: Muralidhar Andoorveedu <[email protected]> commit daddc19 Author: Muralidhar Andoorveedu <[email protected]> Date: Wed May 1 05:56:53 2024 +0000 Formatting Signed-off-by: Muralidhar Andoorveedu <[email protected]> commit 1be32c8 Author: Muralidhar Andoorveedu <[email protected]> Date: Wed May 1 05:55:12 2024 +0000 Revert "PyNCCL changes" This reverts commit 99bb187. commit 99bb187 Author: Muralidhar Andoorveedu <[email protected]> Date: Wed May 1 05:29:42 2024 +0000 PyNCCL changes Signed-off-by: Muralidhar Andoorveedu <[email protected]> commit bd12e70 Author: Muralidhar Andoorveedu <[email protected]> Date: Tue Apr 30 22:46:12 2024 +0000 Fixed testing errors Signed-off-by: Muralidhar Andoorveedu <[email protected]> commit fbb2b2e Author: Muralidhar Andoorveedu <[email protected]> Date: Sat Apr 27 08:48:36 2024 +0000 Formatting Signed-off-by: Muralidhar Andoorveedu <[email protected]> commit 06609d9 Author: Muralidhar Andoorveedu <[email protected]> Date: Sat Apr 27 08:39:03 2024 +0000 Pipeline Parallel Signed-off-by: Muralidhar Andoorveedu <[email protected]> Signed-off-by: Muralidhar Andoorveedu <[email protected]>
Signed-off-by: Muralidhar Andoorveedu <[email protected]>
Signed-off-by: Muralidhar Andoorveedu <[email protected]>
Signed-off-by: Muralidhar Andoorveedu <[email protected]>
Signed-off-by: Muralidhar Andoorveedu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FILL IN THE PR DESCRIPTION HERE
FIX #xxxx (link existing issues this PR will resolve)
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]
for bug fixes.[CI/Build]
for build or continuous integration improvements.[Doc]
for documentation fixes and improvements.[Model]
for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]
For changes on the vLLM frontend (e.g., OpenAI API server,LLM
class, etc.)[Kernel]
for changes affecting CUDA kernels or other compute kernels.[Core]
for changes in the core vLLM logic (e.g.,LLMEngine
,AsyncLLMEngine
,Scheduler
, etc.)[Hardware][Vendor]
for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]
).[Misc]
for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.sh
to format your code.docs/source/
if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-required
and might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-required
label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!