[Kernel] Raise an exception in MoE kernel if the batch size is larger then 65k #5939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cadedaniel
reviewed
Jun 27, 2024
| @@ -392,6 +392,11 @@ def fused_experts(hidden_states: torch.Tensor, | |||
| M, _ = hidden_states.shape | |||
| E, N, _ = w1.shape | |||
|
|
|||
| if M > 65536: | |||
There was a problem hiding this comment.
We need to catch the second invocation which is 2x the first, right?
WoosukKwon
reviewed
Jun 27, 2024
The weird thing is when the batch size is too high it happens in the first invocation. This is also a puzzle to me..
It's possible a Triton limitation but I don't have more time to dive into more... |
cadedaniel
approved these changes
Jun 28, 2024
|
To speed up the CI queue, I've cancelled the distributed tests for the latest CI run in this PR since they won't pass anyway until #5905 has been merged. Now that it has been merged, please merge |
llmpros
pushed a commit
to llmpros/vllm
that referenced
this pull request
Jun 30, 2024
robertgshaw2-neuralmagic
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5938 for details.
This PR raises an exception in the MoE kernel when the batch size is too large, which likely causes illegal memory access.