Skip to content

Conversation

ejkorol
Copy link
Member

@ejkorol ejkorol commented Aug 22, 2025

Overview

Using a basename with the hashrouter is problematic in this case because the deployed url is https://vltpkg.github.io/benchmarks/, however with the basename set to /benchmarks the actual url is https://vltpkg.github.io/benchmarks/#/benchmarks/ since the hashrouter will ignore everything up until the #

It also fixes the issue with loading the data that is prefixed with the date, instead just loads the chart data prefixed with /latest and removes the new Date() helpers in the constants dir.

This will work ontop of #19

Solution

Remove the basename from the createHashRouter call in routes.tsx
Update the data fetching to use the /latest prefix instead of the date prefix.

@ejkorol ejkorol marked this pull request as ready for review August 22, 2025 17:35
- removes date prefix for the chart data, instead relies on `/latest` to
  fetch that data.
- removes the `new Date()` helpers
@ejkorol ejkorol force-pushed the ejkorol/fix-benchmark-hashrouter branch from e4ec0f4 to 7a7db10 Compare August 22, 2025 18:09
@ejkorol ejkorol merged commit 0e0110f into main Aug 22, 2025
35 checks passed
@ejkorol ejkorol deleted the ejkorol/fix-benchmark-hashrouter branch August 22, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant