Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Using a
basename
with the hashrouter is problematic in this case because the deployed url ishttps://vltpkg.github.io/benchmarks/
, however with thebasename
set to/benchmarks
the actual url ishttps://vltpkg.github.io/benchmarks/#/benchmarks/
since thehashrouter
will ignore everything up until the#
It also fixes the issue with loading the data that is prefixed with the date, instead just loads the chart data prefixed with
/latest
and removes thenew Date()
helpers in theconstants
dir.This will work ontop of #19
Solution
Remove the
basename
from thecreateHashRouter
call inroutes.tsx
Update the data fetching to use the
/latest
prefix instead of the date prefix.