-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a11y): stack-view - no proper heading hierarchy maintained in the page #1392
base: main
Are you sure you want to change the base?
Conversation
👋 @andyfeds,
Thank you, 🤖 Clarity Release Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are approved
This PR introduces visual changes: 952f331
|
This PR introduces visual changes: c636c9d
|
This PR introduces visual changes: 079ec02
|
This PR introduces visual changes: 08f14d1
|
This PR introduces visual changes: 020c3ee
|
Contains breaking changes, will be part of v18 release. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
No proper heading hierarchy maintained in the page in case of a stack-block component, as the role is fixed as "heading".
If a user wants to change or omit the role, they can't, because our current implementation forces the heading role and level.
Issue Number: CDE-1634
What is the new behavior?
The below changes are made as mentioned in the JIRA ticket:
A new input
clrSbAriaRole
is added to the stack-block, so the user can pass/configure the aria role.Does this PR introduce a breaking change?
Other information