-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assambar/47 ignore option #126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall changes LGTM. The refactor and new tests are great 😄. I added a few minor comments.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides @Angelmmiguel comments, neat contribution!
@assambar thank you for the update! Please, rebase the changes from |
``` $$ target/debug/wws . --ignore 'src/**/*' --ignore 'target/**/*' --ignore 'docs/**/*' --ignore 'crates/**/*' | ts May 26 08:49:33 ⚙️ Loading routes from: . May 26 08:49:35 ⏳ Loading workers from 14 routes... May 26 08:50:13 ✅ Workers loaded in 38.128146575s. ... ```
4449258
to
ce0d458
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Amazing contribution 😄
--ignore
option that accepts full glob patterns (one can exclude files as well as folders)router/files
to remove dependency from Config, also added a few more unit testsHere is an example run from the repo's main folder
It closes #47. It closes #103