Add apply_cmd_bat to Tiltfile for Windows #155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- prevents errors due to default `> /dev/null` on windows by replacing it with windows-compatible `> NUL` - From tilt docs: command_bat ( Union [ str , List [ str ]]) – If non-empty and on Windows, takes precedence over command . Ignored on other platforms. If a string, executed as a Windows batch command executed with cmd /S /C ; if a list, will be passed to the operating system as program name and args.
|
Here's a quick demo to show error resolution: apply_cmd_bat_demo.mp4 |
|
alternatively to removing output command env var, create 2: one each for cmd and default. Either way, use (or non use) should be consistent |
Addressed in b0ed75f -- how does that look @ccheetham? |
ccheetham
approved these changes
Dec 20, 2022
weatherforecast-steeltoe/Tiltfile
Outdated
| " --build-env BP_DEBUG_ENABLED=true" + | ||
| " --namespace " + NAMESPACE + | ||
| " --yes " + | ||
| " > NUL " + # windows-compatible "output to null" |
There was a problem hiding this comment.
Suggested change
| " > NUL " + # windows-compatible "output to null" | |
| " > NUL " + |
There was a problem hiding this comment.
Also remove OUTPUT_TO_NULL_COMMAND declaration at line 4
| @@ -14,6 +14,14 @@ k8s_custom_deploy( | |||
| " --yes " + | |||
| OUTPUT_TO_NULL_COMMAND + | |||
There was a problem hiding this comment.
Suggested change
| OUTPUT_TO_NULL_COMMAND + | |
| " > /dev/null " + |
|
Now that |
|
closing based on latest comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #149 (thanks @vrabbi for the solution!)
Prevents errors due to default
> /dev/nullon windows by replacing it with windows-compatible> NULFrom tilt docs: