Add new node-express sample #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trisberg
force-pushed
the
new-node-express
branch
from
5562c74 to
03f779f
Compare
trisberg
force-pushed
the
new-node-express
branch
from
03f779f to
0b6737d
Compare
trisberg
force-pushed
the
new-node-express
branch
from
ac79d2f to
0bf9b4e
Compare
ericbottard
reviewed
Jan 24, 2025
node-express/accelerator.axl
Outdated
| } | ||
|
|
||
| if (#deploymentType == 'none') { | ||
| select(!"deploy/**") |
There was a problem hiding this comment.
Small nitpick, but can't this be pulled out of that (then unnecessary) if and put at the end?
|
Shouldn't this come with a change to tp-for-k8s-manifests/accelerators.yaml? |
Yes, once we decide this is a go, then we should add it to those files |
I added them to the resource definition files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.