Address comments

Signed-off-by: Wenqi Qiu <[email protected]>
vmware-tanzu · Aug 9, 2024 · 627f075 · 627f075
1 parent 77cacc1
commit 627f075
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 6 deletions.
diff --git a/build/yaml/samples/nsx_v1alpha1_vpcnetworkconfigurations.yaml b/build/yaml/samples/nsx_v1alpha1_vpcnetworkconfigurations.yaml
@@ -3,12 +3,8 @@ kind: VPCNetworkConfiguration
 metadata:
   name: vpc-network-config1
 spec:
-  defaultGatewayPath: /infra/tier-0s/t0
-  edgeClusterPath: /infra/sites/default/enforcement-points/default/edge-clusters/2d9df59f-6dc6-4911-8865-21fadc23d4da
   defaultSubnetSize: 32
   nsxProject: proj-1
-  externalIPv4Blocks:
-    - block1
   privateIPs:
     - 172.26.0.0/16
     - 172.36.0.0/16

diff --git a/pkg/controllers/networkinfo/vpcnetworkconfig_handler.go b/pkg/controllers/networkinfo/vpcnetworkconfig_handler.go
@@ -101,7 +101,7 @@ var VPCNetworkConfigurationPredicate = predicate.Funcs{
 func buildNetworkConfigInfo(vpcConfigCR v1alpha1.VPCNetworkConfiguration) (*commontypes.VPCNetworkConfigInfo, error) {
 	org, project, err := nsxtProjectPathToId(vpcConfigCR.Spec.NSXProject)
 	if err != nil {
-		log.Error(err, "failed to parse nsx-t project in network config", "Project Path", vpcConfigCR.Spec.NSXProject)
+		log.Error(err, "failed to parse NSX project in network config", "Project Path", vpcConfigCR.Spec.NSXProject)
 		return nil, err
 	}
 

diff --git a/pkg/nsx/services/vpc/compare.go b/pkg/nsx/services/vpc/compare.go
@@ -9,7 +9,7 @@ import (
 // currently we only support appending public/private cidrs
 // so only comparing list size is enough to identify if vcp changed
 func IsVPCChanged(nc common.VPCNetworkConfigInfo, vpc *model.Vpc) bool {
-	if len(nc.PrivateIPs) != len(vpc.PrivateIpv4Blocks) {
+	if len(nc.PrivateIPs) != len(vpc.PrivateIps) {
 		return true
 	}