Add keyFunc for shared resources #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While listing the resources in cleanup, each resource type should be added in keyFunc. Add shared resources to keyFunc
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v4.2.0 #1012 +/- ##
==========================================
- Coverage 74.90% 74.84% -0.06%
==========================================
Files 118 118
Lines 16377 16389 +12
==========================================
Hits 12267 12267
- Misses 3343 3355 +12
Partials 767 767
|
|
/e2e |
1 similar comment
|
/e2e |
dantingl
approved these changes
Jan 23, 2025
|
/e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While listing the resources in cleanup, each resource type should be added in keyFunc.
Add shared resources to keyFunc
while disable cluster:
2025-01-23 06:38:28.141 ^[[34mINFO^[[0m ^[[33mvpc/vpc.go:1003^[[0m Cleaning up sharedResources {"Count": 0}
2025-01-23 06:38:28.335 ^[[31mERROR^[[0m ^[[33mvpc/vpc.go:299^[[0m Failed to query share {"query": "resource_type:Share AND tags.scope:ncp\/cluster AND tags.tag:af33355b-c022-4de2-b365-27644454a57f", "error": "couldn't create key for object &{Links:[] Schema: Self: Revision:0xc0057314c8 CreateTime:0xc005731418 CreateUser:0xc006dca4c0 LastModifiedTime:0xc0057313a8 LastModifiedUser:0xc006dca230 Protection:0xc006dca460 SystemOwned:0xc00573144f Description: DisplayName:0xc006dca250 Id:0xc006dca1f0 ResourceType:0xc006dca480 Tags:[{Scope:0xc006dca320 Tag:0xc006dca340} {Scope:0xc006dca3b0 Tag:0xc006dca3d0}] OriginSiteId: OwnerId:0xc006dca400 ParentPath:0xc006dca1a0 Path:0xc006dca420 RealizationId:0xc006dca180 RelativePath:0xc006dca440 RemotePath:0xc006dca270 UniqueId:0xc006dca210 Children:[] MarkedForDelete:0xc00573137f Overridden:0xc0057313ff SharedWith:[/orgs/default] SharingStrategy:0xc006dca4a0}: keyFunc doesn't support unknown type"}
2025-01-23 06:38:28.335 ^[[34mINFO^[[0m ^[[33mvpc/vpc.go:1018^[[0m Cleaning up shares {"Count": 0}
Test Done: