Improve realizedstate check for resources with dependency #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v4.2.0 #1014 +/- ##
==========================================
+ Coverage 74.84% 74.86% +0.01%
==========================================
Files 118 118
Lines 16389 16409 +20
==========================================
+ Hits 12267 12285 +18
- Misses 3355 3357 +2
Partials 767 767
|
TaoZou1
reviewed
Jan 26, 2025
yanjunz97
force-pushed
the
improve-lbs-rs-420
branch
2 times, most recently
from
32b1da0 to
be73e26
Compare
TaoZou1
previously approved these changes
Jan 26, 2025
timdengyun
reviewed
Jan 26, 2025
yanjunz97
force-pushed
the
improve-lbs-rs-420
branch
from
be73e26 to
0a73ad3
Compare
TaoZou1
previously approved these changes
Jan 26, 2025
Signed-off-by: Yanjun Zhou <[email protected]>
yanjunz97
force-pushed
the
improve-lbs-rs-420
branch
from
0a73ad3 to
236fead
Compare
TaoZou1
approved these changes
Jan 26, 2025
|
We need pick to main branch |
yanjunz97
added a commit
to yanjunz97/nsx-operator
that referenced
this pull request
Jan 26, 2025
…zu#1014) NSX LBS realization has dependency on the gateway-interface. If gateway-interface is not realized before NSX LBS realization timeout, the realized state API will return a ProviderNotReady error. But later on the NSX LBS realization can become Realized after the gateway-interface realization succeeds. Thus for NSX operator, we enhance the realized state check to Check gateway-interface when check the VPC realized state Retry when ProviderNotReady error is detected Signed-off-by: Yanjun Zhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSX LBS realization has dependency on the gateway-interface. If gateway-interface is not realized
before NSX LBS realization timeout, the realized state API will return a ProviderNotReady error.
But later on the NSX LBS realization can become Realized after the gateway-interface realization
succeeds. Thus for NSX operator, we enhance the realized state check to