Change DefaultSubnetAccessMode to DefaultAccessModeForPod #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxiaopei
force-pushed
the
topic/lxiaopei/defaultPodType
branch
4 times, most recently
from
d59d816
to
409cf14
Compare
|
/e2e |
wenqiq
force-pushed
the
topic/lxiaopei/defaultPodType
branch
2 times, most recently
from
0f2c174
to
479ea7d
Compare
|
/e2e |
As we discussed, we want to set default Pod Subnet type in Namespace settings, and always keep VMs default to "Private" Subnets. Also, besides "Public" and "Private" access mode, also add "Project" and "Isolated" for user to choose. Update Signed-off-by: Wenqi Qiu <[email protected]>
Signed-off-by: Wenqi Qiu <[email protected]>
wenqiq
force-pushed
the
topic/lxiaopei/defaultPodType
branch
from
8e0ab0b
to
250f011
Compare
wenqiq
reviewed
Jul 29, 2024
| message := fmt.Sprintf("invalid network config %s for namespace %s, missing private cidr", ncName, ns) | ||
| r.namespaceError(&ctx, obj, message, nil) | ||
| return common.ResultRequeueAfter10sec, nil | ||
| } |
|
No need this PR any more. change in #623 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we discussed, we want to set default Pod Subnet type in Namespace settings, and always keep VMs default to "Private" Subnets.
Also, besides "Public" and "Private" access mode, also add "Project" and "Isolated" for user to choose.