Fix AccessMode name in NSX request body #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxiaopei
reviewed
Aug 15, 2024
lxiaopei
reviewed
Aug 15, 2024
lxiaopei
reviewed
Aug 15, 2024
lxiaopei
reviewed
Aug 15, 2024
|
/e2e |
dantingl
reviewed
Aug 15, 2024
wenqiq
force-pushed
the
topic/wenqi/rename-resource
branch
from
b1fdabe
to
016bc83
Compare
fix subnet e2e test Signed-off-by: Wenqi Qiu <[email protected]>
wenqiq
force-pushed
the
topic/wenqi/rename-resource
branch
from
016bc83
to
e5c3315
Compare
heypnus
approved these changes
Aug 16, 2024
zhengxiexie
approved these changes
Aug 16, 2024
wenqiq
added a commit
to wenqiq/nsx-operator
that referenced
this pull request
Aug 16, 2024
Rename AccessMode `PrivateTGW` to `Private_TGW` in the NSX request body and fix the subnet e2e test Signed-off-by: Wenqi Qiu <[email protected]>
dantingl
pushed a commit
that referenced
this pull request
Aug 17, 2024
Rename AccessMode `PrivateTGW` to `Private_TGW` in the NSX request body and fix the subnet e2e test Signed-off-by: Wenqi Qiu <[email protected]>
dantingl
reviewed
Aug 19, 2024
| AccessModePrivate string = "Private" | ||
| AccessModeProject string = "PrivateTGW" | ||
| ) | ||
|
|
| @@ -1,7 +1,7 @@ | |||
| apiVersion: crd.nsx.vmware.com/v1alpha1 | |||
| kind: SubnetPort | |||
| metadata: | |||
| name: port-1 | |||
| name: port-e2e-test-1 | |||
There was a problem hiding this comment.
What's the reason to change the name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix AccessMode name in NSX request body when creating subnet and fix subnet e2e test