-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove staticroute finalizer #794
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #794 +/- ##
==========================================
+ Coverage 48.73% 48.79% +0.05%
==========================================
Files 94 94
Lines 12249 12283 +34
==========================================
+ Hits 5970 5993 +23
- Misses 5777 5789 +12
+ Partials 502 501 -1
|
e3f6489
to
3189009
Compare
/e2e |
3189009
to
b126df4
Compare
b126df4
to
906a18c
Compare
906a18c
to
e37cb56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e37cb56
to
34f5691
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
34f5691
to
8b58b87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/e2e |
The finalizer may block the deletion since the NSX resource may take long time to delete. Remove the finalizer so the deleting operation will return immediately
8b58b87
to
d3d5d6e
Compare
/e2e |
The finalizer may block the deletion since the NSX resource may take long time to delete.
Remove the finalizer so the deleting operation will return immediately
Test Done: