Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pre-VPC] Periodically sync pre-created VPC to NetworkInfo CR #799

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wenyingd
Copy link
Contributor

This change has introduce a goroutine to periodically get the pre-created VPC configuration from NSX, and sync to the referred NetworkInfo CR's status if its private IPs are changed. The sync interval is 10m.

…orkInfo CR

This change has introduce a goroutine to periodically get the pre-created VPC
configuration from NSX, and sync to the referred NetworkInfo CR's status if
private IPs are changed. The sync interval is 10m.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 84.05797% with 11 lines in your changes missing coverage. Please review.

Project coverage is 48.92%. Comparing base (b990849) to head (d284a7f).

Files with missing lines Patch % Lines
.../controllers/networkinfo/networkinfo_controller.go 74.41% 10 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #799      +/-   ##
==========================================
+ Coverage   48.73%   48.92%   +0.18%     
==========================================
  Files          94       94              
  Lines       12249    12316      +67     
==========================================
+ Hits         5970     6026      +56     
- Misses       5777     5787      +10     
- Partials      502      503       +1     
Flag Coverage Δ
unit-tests 48.92% <84.05%> (+0.18%) ⬆️
Files with missing lines Coverage Δ
pkg/nsx/services/vpc/vpc.go 30.34% <100.00%> (+2.14%) ⬆️
.../controllers/networkinfo/networkinfo_controller.go 41.60% <74.41%> (+6.81%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants