Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug where the namespace cannot be deleted #800

Open
wants to merge 1 commit into
base: v4.2.0
Choose a base branch
from

Conversation

zhengxiexie
Copy link
Contributor

@zhengxiexie zhengxiexie commented Oct 14, 2024

Fix the bug where the namespace cannot be deleted due to the username of the namespace deletion.
Use global log.

Test Done:
On VC UI, namespace can be created and deleted succesfully.

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 48.34%. Comparing base (8f0c8e4) to head (f9b19de).

Files with missing lines Patch % Lines
pkg/controllers/namespace/namespace_controller.go 0.00% 23 Missing ⚠️
pkg/controllers/subnetset/subnetset_webhook.go 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           v4.2.0     #800      +/-   ##
==========================================
- Coverage   48.43%   48.34%   -0.09%     
==========================================
  Files          94       94              
  Lines       11940    11962      +22     
==========================================
  Hits         5783     5783              
- Misses       5663     5685      +22     
  Partials      494      494              
Flag Coverage Δ
unit-tests 48.34% <0.00%> (-0.09%) ⬇️
Files with missing lines Coverage Δ
pkg/controllers/subnetset/subnetset_webhook.go 0.00% <0.00%> (ø)
pkg/controllers/namespace/namespace_controller.go 15.15% <0.00%> (-2.34%) ⬇️

@zhengxiexie zhengxiexie force-pushed the topic/zhengxie/v4.2.0_webhook_log branch 2 times, most recently from 72dd30e to 748bed4 Compare October 14, 2024 05:10
… of the namespace deletion.

Use global log.

Signed-off-by: Xie Zheng <[email protected]>
@zhengxiexie zhengxiexie force-pushed the topic/zhengxie/v4.2.0_webhook_log branch from 748bed4 to f9b19de Compare October 14, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants