-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete the vs/lb pool created for pre-created VPC #802
base: v4.2.0
Are you sure you want to change the base?
Conversation
The pre-created VPC is shared by many ns. Once the ns deleted, the pre-created VPC will not be deleted. But the vs/lb pool created for service under pre-created VPC should be released. Delete vpc/lb pool created for SLB by NCP in cleanup
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v4.2.0 #802 +/- ##
==========================================
- Coverage 48.43% 48.06% -0.37%
==========================================
Files 94 94
Lines 11940 12039 +99
==========================================
+ Hits 5783 5787 +4
- Misses 5663 5758 +95
Partials 494 494
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. There is a little bit weird that placing the delete operation in the IsSharedVPCNamespaceByNS
function.
The pre-created VPC is shared by many ns. Once the ns deleted, the pre-created VPC will not be deleted.
But the vs/lb pool created for service under pre-created VPC should be released.
Delete vpc/lb pool created for SLB by NCP in cleanup