Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove id comparison when deleting nsx resource by NamespacedName #994

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove id comparison when deleting nsx resource by NamespacedName #994

wants to merge 2 commits into from
+139 −363

Conversation

yanjunz97
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.04651% with 6 lines in your changes missing coverage. Please review.

Project coverage is 74.47%. Comparing base (5493463) to head (92555c8).

Files with missing lines Patch % Lines
pkg/controllers/subnet/subnet_controller.go 50.00% 2 Missing and 1 partial ⚠️
...kg/controllers/subnetport/subnetport_controller.go 50.00% 1 Missing and 1 partial ⚠️
pkg/nsx/services/staticroute/staticroute.go 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #994      +/-   ##
==========================================
+ Coverage   74.19%   74.47%   +0.28%     
==========================================
  Files         118      118              
  Lines       16410    16285     -125     
==========================================
- Hits        12175    12128      -47     
+ Misses       3465     3389      -76     
+ Partials      770      768       -2
Flag Coverage Δ
unit-tests 74.47% <86.04%> (+0.28%) ⬆️
Files with missing lines Coverage Δ
...trollers/networkpolicy/networkpolicy_controller.go 74.82% <ø> (-0.51%) ⬇️
pkg/controllers/pod/pod_controller.go 62.08% <100.00%> (+0.50%) ⬆️
...ollers/securitypolicy/securitypolicy_controller.go 77.46% <ø> (-0.16%) ⬇️
.../controllers/staticroute/staticroute_controller.go 78.34% <100.00%> (+1.67%) ⬆️
pkg/controllers/subnetset/subnetset_controller.go 76.36% <100.00%> (+0.13%) ⬆️
...ervices/ipaddressallocation/ipaddressallocation.go 64.10% <100.00%> (+17.31%) ⬆️
pkg/nsx/services/subnet/subnet.go 70.18% <ø> (-0.09%) ⬇️
pkg/nsx/services/staticroute/staticroute.go 78.90% <92.85%> (+1.63%) ⬆️
...kg/controllers/subnetport/subnetport_controller.go 75.00% <50.00%> (+0.25%) ⬆️
pkg/controllers/subnet/subnet_controller.go 71.69% <50.00%> (-0.24%) ⬇️

@yanjunz97 yanjunz97 force-pushed the improve-deletion-by-name branch 2 times, most recently from 1303fee to f1b4a20 Compare January 7, 2025 07:19
@yanjunz97 yanjunz97 force-pushed the improve-deletion-by-name branch from f1b4a20 to 6dd07a0 Compare January 22, 2025 03:29
@yanjunz97 yanjunz97 marked this pull request as ready for review January 22, 2025 05:49
@yanjunz97 yanjunz97 force-pushed the improve-deletion-by-name branch from 6dd07a0 to c0c121c Compare February 5, 2025 07:07
wenyingd
wenyingd reviewed Feb 6, 2025
View reviewed changes
Copy link
Contributor

@wenyingd wenyingd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, two nits

pkg/controllers/staticroute/staticroute_controller.go Outdated Show resolved Hide resolved
pkg/controllers/subnetset/subnetset_controller.go Outdated Show resolved Hide resolved
@yanjunz97 yanjunz97 force-pushed the improve-deletion-by-name branch 2 times, most recently from 8543300 to 93c8f4b Compare February 6, 2025 07:55
@yanjunz97 yanjunz97 requested a review from wenyingd February 7, 2025 06:03
wenyingd
wenyingd previously approved these changes Feb 8, 2025
View reviewed changes
Copy link
Contributor

@wenyingd wenyingd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit.

pkg/controllers/staticroute/staticroute_controller.go Outdated Show resolved Hide resolved
@yanjunz97 yanjunz97 force-pushed the improve-deletion-by-name branch from 93c8f4b to f95a7d7 Compare February 8, 2025 06:23
wenyingd
wenyingd previously approved these changes Feb 8, 2025
View reviewed changes
Copy link
Contributor

@wenyingd wenyingd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanjunz97
Improve StaticRoute deletion
92555c8 
Signed-off-by: Yanjun Zhou <[email protected]>
@yanjunz97 yanjunz97 force-pushed the improve-deletion-by-name branch from 599a2f1 to 92555c8 Compare February 10, 2025 03:55
timdengyun
timdengyun approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@timdengyun timdengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdengyun timdengyun timdengyun approved these changes

@wenyingd wenyingd wenyingd left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yanjunz97 @codecov-commenter @wenyingd @timdengyun @vmwclabot