Implement proposal to allow Pinniped custom resources to ref configmaps or secrets for CA bundles #1996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfryanr
reviewed
Jun 20, 2024
cfryanr
reviewed
Jun 20, 2024
cfryanr
reviewed
Jun 20, 2024
ashish-amarnath
force-pushed
the
ca-bundles-ref
branch
from
1eea7f3 to
60d32a4
Compare
cfryanr
reviewed
Jun 24, 2024
cfryanr
reviewed
Jun 24, 2024
cfryanr
reviewed
Jun 24, 2024
cfryanr
reviewed
Jun 24, 2024
cfryanr
reviewed
Jun 24, 2024
cfryanr
reviewed
Jun 24, 2024
cfryanr
reviewed
Jun 24, 2024
cfryanr
reviewed
Jun 24, 2024
cfryanr
reviewed
Jun 24, 2024
ashish-amarnath
force-pushed
the
ca-bundles-ref
branch
from
60d32a4 to
cc4dbdc
Compare
cfryanr
reviewed
Jun 25, 2024
cfryanr
reviewed
Jun 25, 2024
ashish-amarnath
force-pushed
the
ca-bundles-ref
branch
2 times, most recently
from
f17b0de to
a6e4b2c
Compare
cfryanr
reviewed
Jun 25, 2024
ashish-amarnath
force-pushed
the
ca-bundles-ref
branch
from
a6e4b2c to
1f28d70
Compare
ashish-amarnath
commented
Jun 27, 2024
ashish-amarnath
commented
Jun 27, 2024
ashish-amarnath
commented
Jun 27, 2024
ashish-amarnath
force-pushed
the
ca-bundles-ref
branch
3 times, most recently
from
239fa85 to
f9c6882
Compare
ashish-amarnath
force-pushed
the
ca-bundles-ref
branch
from
f9c6882 to
ff1cdfa
Compare
…es to not update the status
fix a typo where we intended to use a configmap instead of a secret Signed-off-by: Ashish Amarnath <[email protected]> Co-authored-by: Ryan Richard <[email protected]>
Even when the authenticator is found in the cache, try to update its status. Failing to do so would mean that the actual status will not be overwritten by the controller's newly computed desired status. Co-authored-by: Ashish Amarnath <[email protected]>
…iped is installed Signed-off-by: Ashish Amarnath <[email protected]>
Signed-off-by: Ashish Amarnath <[email protected]>
Co-authored-by: Ashish Amarnath <[email protected]>
Co-authored-by: Ashish Amarnath <[email protected]>
… WebhookAuthenticator Signed-off-by: Ashish Amarnath <[email protected]>
Signed-off-by: Ashish Amarnath <[email protected]>
Signed-off-by: Ashish Amarnath <[email protected]>
…sor_tls_spec_test.go
…upervisor_tls_spec_test.go
Signed-off-by: Ashish Amarnath <[email protected]> Co-authored-by: Ashish Amarnath <[email protected]>
Signed-off-by: Ashish Amarnath <[email protected]>
This was referenced Aug 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement proposal to allow Pinniped CRs to source CA bundles, for client-side TLS validation, from secrets and configMaps
Fixes #1886
This PR also adds a new "Status" printer column to the table output for WebhookAuthenticator and JWTAuthenticator. The value shown in the column is the
status.Phaseof the resource.This PR also fixes a bug for JWTAuthenticators and WebhookAuthenticators where their
statuswas not always being updated after its initial creation.Release note: