Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update workflows to run on tags #599

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Update workflows to run on tags #599

merged 1 commit into from
Nov 22, 2023

Conversation

mpanchajanya
Copy link
Contributor

@mpanchajanya mpanchajanya commented Nov 20, 2023 •
edited
Loading

What this PR does / why we need it

  • Update build and test workflows to run on tags

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Release note

Additional information

Special notes for your reviewer

@mpanchajanya mpanchajanya self-assigned this Nov 20, 2023
@mpanchajanya mpanchajanya marked this pull request as ready for review November 20, 2023 12:40
@mpanchajanya mpanchajanya requested a review from a team as a code owner November 20, 2023 12:40
marckhouzam
marckhouzam reviewed Nov 21, 2023
View reviewed changes
Copy link
Contributor

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to add those tags to .github/workflows/cli-coexistence_tests.yaml?

@mpanchajanya mpanchajanya force-pushed the worflows-to-run-on-tags branch from 43db223 to cfd6979 Compare November 22, 2023 12:52
@mpanchajanya
Copy link
Contributor Author

Any reason not to add those tags to .github/workflows/cli-coexistence_tests.yaml?

Updated coexistence tests now. @marckhouzam

marckhouzam
marckhouzam approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!

@marckhouzam marckhouzam added this to the v1.2.0 milestone Nov 22, 2023
@mpanchajanya mpanchajanya merged commit b1166d3 into vmware-tanzu:main Nov 22, 2023
7 checks passed
@marckhouzam marckhouzam added the kind/testing Categorizes issue or PR as related to testing label Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marckhouzam marckhouzam marckhouzam approved these changes

@vuil vuil Awaiting requested review from vuil

@anujc25 anujc25 Awaiting requested review from anujc25

Assignees

@mpanchajanya mpanchajanya

Labels
cla-not-required kind/testing Categorizes issue or PR as related to testing
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mpanchajanya @marckhouzam @vmwclabot