Remove VS name annotation from PVC during CSI restore #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shubham Pampattiwar <[email protected]>
shubham-pampattiwar
force-pushed
the
remove-vs-annotation
branch
from
22b0969
to
453b67b
Compare
|
LGTM |
sseago
approved these changes
Jun 12, 2023
|
@Lyndon-Li @blackpiglet @ywk253100 PTAL! Thank you! |
blackpiglet
approved these changes
Jul 3, 2023
blackpiglet
pushed a commit
to blackpiglet/velero-plugin-for-csi
that referenced
this pull request
Jul 19, 2023
plugin workflow determines whether to restore depends on PVC has the VolumeSnapshot annotation, so change to check the annotation from the pvcFromBackup, not the modified pvc. Signed-off-by: Xun Jiang <[email protected]>
blackpiglet
added a commit
that referenced
this pull request
Jul 21, 2023
Resolve conflict with PR #180
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes vmware-tanzu/velero#6361