Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit the label "velero.io/pvc-namespace-name" length to 63. #187

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Limit the label "velero.io/pvc-namespace-name" length to 63. #187

merged 1 commit into from
Jul 4, 2023

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Jul 4, 2023 •
edited
Loading

  • Limit label length to 63.
  • Use the label const variables from the Velero repository.
  • Add Velero resource usage label for DataUploadResult ConfigMap list query.
  • Adjust UT accordingly.

@blackpiglet blackpiglet marked this pull request as ready for review July 4, 2023 08:13
@blackpiglet blackpiglet changed the title Limit the label "velero.io/pvc-namespace-name"'s length to 63. Limit the label "velero.io/pvc-namespace-name" length to 63. Jul 4, 2023
@Lyndon-Li Lyndon-Li merged commit 57d8cf0 into vmware-tanzu:main Jul 4, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danfengliu danfengliu danfengliu approved these changes

@Lyndon-Li Lyndon-Li Lyndon-Li approved these changes

@reasonerjt reasonerjt Awaiting requested review from reasonerjt

@sseago sseago Awaiting requested review from sseago

Assignees

@blackpiglet blackpiglet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blackpiglet @danfengliu @Lyndon-Li