Fix Error log bug #207
Merged
Fix Error log bug #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shashank Singh <[email protected]>
anshulahuja98
previously approved these changes
Oct 3, 2023
Signed-off-by: Shashank Singh <[email protected]>
| @@ -267,7 +267,8 @@ func GetVolumeSnapshotContentForVolumeSnapshot(volSnap *snapshotv1api.VolumeSnap | |||
| if err != nil { | |||
| if err == wait.ErrWaitTimeout { | |||
| if snapshotContent.Status != nil && snapshotContent.Status.Error != nil { | |||
| log.Errorf("Timed out awaiting reconciliation of volumesnapshot, Volumesnapshotcontent %s has error: %v", snapshotContent.Name, snapshotContent.Status.Error.Message) | |||
| log.Errorf("Timed out awaiting reconciliation of volumesnapshot, Volumesnapshotcontent %s has error: %v", snapshotContent.Name, *snapshotContent.Status.Error.Message) | |||
| return nil, errors.Errorf("CSI got timed out with error: %v", *snapshotContent.Status.Error.Message) | |||
There was a problem hiding this comment.
unsure about this return statement here, we return on line 276 with the original error, right ?
There was a problem hiding this comment.
Hi @shubham-pampattiwar, here in line 268 the err is compared to wait.ErrWaitTimeout which is timed out waiting for the condition
and while returning this error message is floated in the velero rather than actual error.
So, I've added this return statement for floating actual error
anshulahuja98
approved these changes
Oct 26, 2023
sseago
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved error floatation during csi-polling timeout scenario.