feat: add support for archive snapshot type

[okuuva]

Fixes vmware-tanzu/velero#7371.

Signed-off-by: Oula Kuuva [email protected]

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 35.29412% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 29.73%. Comparing base (a450b02) to head (bfe0ef1).

Files	Patch %	Lines
velero-plugin-for-gcp/volume_snapshotter.go	35.29%	10 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
+ Coverage   29.15%   29.73%   +0.58%     
==========================================
  Files           3        3              
  Lines         518      528      +10     
==========================================
+ Hits          151      157       +6     
- Misses        355      359       +4     
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tuusberg]

@okuuva I just opened a draft PR in this repo that solves the same problem and saw yours :) Great job!
I ran into an issue when I was working on my PR: Snapshot type in Google SDK v0.63.0 does not have SnapshotType property. I solved it by upgrading the SDK to the latest version (v0.167.0) and also bumped Go version, which, most probably deserves a separate PR.

[blackpiglet]

@okuuva
Thanks for the contribution.
The PR misses using the added snapshot type to create the snapshot.

Two places may need the snapshot type.

velero-plugin-for-gcp/velero-plugin-for-gcp/volume_snapshotter.go

Lines 302 to 306 in a450b02

	gceSnap := compute.Snapshot{
	Name: snapshotName,
	Description: getSnapshotTags(tags, disk.Description, b.log),
	SourceDisk: disk.SelfLink,
	}

velero-plugin-for-gcp/velero-plugin-for-gcp/volume_snapshotter.go

Lines 326 to 330 in a450b02

	gceSnap := compute.Snapshot{
	Name: snapshotName,
	Description: getSnapshotTags(tags, disk.Description, b.log),
	SourceDisk: disk.SelfLink,
	}

[okuuva]

@okuuva I just opened a draft PR in this repo that solves the same problem and saw yours :) Great job!

Thanks!

I ran into an issue when I was working on my PR: Snapshot type in Google SDK v0.63.0 does not have SnapshotType property. I solved it by upgrading the SDK to the latest version (v0.167.0) and also bumped Go version, which, most probably deserves a separate PR.

Hmmh, where did you get the v0.63.0? To me it seems like it's currently sitting at v0.143.0 which isn't the latest but does include the SnapshotType property.

I personally try to separate version bumps from functional changes unless they're absolutely necessary. While bumping both the SDK version and Go version are probably a good idea I'd do those in separate PR(s).

[okuuva]

@okuuva Thanks for the contribution. The PR misses using the added snapshot type to create the snapshot.

Two places may need the snapshot type.

velero-plugin-for-gcp/velero-plugin-for-gcp/volume_snapshotter.go

Lines 302 to 306 in a450b02

	gceSnap := compute.Snapshot{
	Name: snapshotName,
	Description: getSnapshotTags(tags, disk.Description, b.log),
	SourceDisk: disk.SelfLink,
	}

velero-plugin-for-gcp/velero-plugin-for-gcp/volume_snapshotter.go

Lines 326 to 330 in a450b02

	gceSnap := compute.Snapshot{
	Name: snapshotName,
	Description: getSnapshotTags(tags, disk.Description, b.log),
	SourceDisk: disk.SelfLink,
	}

...well, that was an awkward oversight from my part 😅 Fixed it now, thanks!

[tuusberg]

@okuuva nevermind, it seems my fork was outdated, it's 0.143.0 in the main branch and it would work without any modification.

[blackpiglet]

@okuuva
Thanks for your contribution. This PR looks good. Just delete the changelog file, then we can merge this PR.

[gokulkrishnaa]

@blackpiglet what release version can we expect this fix to be a part of?

[blackpiglet]

This plugin will be shipped with Velero v1.14.0; the version should be v1.10.0.