Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update support matrix for WCP. #542

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

lipingxue
Copy link
Collaborator

@lipingxue lipingxue commented Jul 7, 2023

Signed-off-by: Liping Xue [email protected]

What this PR does / why we need it:
This change is to update WCP compatibility matrix to remove the following row:
Velero Plugin for vSphere Version: 1.4.2
vSphere Version: 7.0U3h
Velero Version: 1.9.2
Velero vSphere Operator Version: 1.3.0
Data Manager Version: 1.2.0

The reason we need to remove the above combination is because Velero vSphere Operator Pod will restart periodically with this combination and may cause installing Velero vSphere plugin in TKC failed.

The following are detail explanations for this issue:

  1. During Velero vSphere operator reconcile, when a TKC is created, operator need to create a ProviderServiceAccount CR. Tkc controller watches for these PSA and creates a secret in specific guest clusters. (PSA account and secret are required to install Velero vSphere plugin in guest cluster). In this case, the operator failed to create ProviderServiceAccount CR since it is crashed. Therefore, installing Velero vSphere plugin in TKC will fail.
  2. we found that if TKC is created before Velero vSphere Operator pod is created, PSA account and secret may be created before the Velero vSphere Operator Pod crashed. In this case, installing Velero vSphere plugin in TKC will succeed. But this no guarantee that this combination will work all the time.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@svcbot-qecnsdp
Copy link

Sorry, some of the pre-check tests are failing for this PR !

Please check the Jenkins job for more details
https://container-dp.svc.eng.vmware.com/job/CNSDP-CI/825/

@xing-yang
Copy link
Contributor

The change LGTM.
Can you fix DCO?

Signed-off-by: Liping Xue [email protected]

Signed-off-by: Liping Xue <[email protected]>
@lipingxue
Copy link
Collaborator Author

The change LGTM. Can you fix DCO?

Fixed. Please take a look. @xing-yang

@svcbot-qecnsdp
Copy link

Sorry, some of the pre-check tests are failing for this PR !

Please check the Jenkins job for more details
https://container-dp.svc.eng.vmware.com/job/CNSDP-CI/826/

Copy link
Contributor

@xing-yang xing-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lipingxue lipingxue merged commit aaefa21 into vmware-tanzu:main Jul 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants