Skip to content

Commit

Permalink
Merge pull request #7727 from danfengliu/fix-1.14-nightly-issues
Browse files Browse the repository at this point in the history
Fix 1.14 nightly issues
  • Loading branch information
danfengliu authored Apr 23, 2024
2 parents d160036 + 8a3f2f4 commit e718a13
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
9 changes: 9 additions & 0 deletions test/e2e/test/test.go
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,15 @@ func (t *TestCase) Backup() error {
RunDebug(context.Background(), veleroCfg.VeleroCLI, veleroCfg.VeleroNamespace, t.BackupName, "")
return errors.Wrapf(err, "Failed to backup resources")
}

// the snapshots of AWS may be still in pending status when do the restore, wait for a while
// to avoid this https://github.com/vmware-tanzu/velero/issues/1799
// TODO remove this after https://github.com/vmware-tanzu/velero/issues/3533 is fixed
if t.UseVolumeSnapshots {
fmt.Println("Waiting 5 minutes to make sure the snapshots are ready...")
time.Sleep(5 * time.Minute)
}

return nil
}

Expand Down
2 changes: 1 addition & 1 deletion test/util/velero/velero_utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -706,7 +706,7 @@ func VeleroAddPluginsForProvider(ctx context.Context, veleroCLI string, veleroNa
stdoutBuf := new(bytes.Buffer)
stderrBuf := new(bytes.Buffer)

installPluginCmd := exec.CommandContext(ctx, veleroCLI, "--namespace", veleroNamespace, "plugin", "add", plugin)
installPluginCmd := exec.CommandContext(ctx, veleroCLI, "--namespace", veleroNamespace, "plugin", "add", plugin, "--confirm")
fmt.Printf("installPluginCmd cmd =%v\n", installPluginCmd)
installPluginCmd.Stdout = stdoutBuf
installPluginCmd.Stderr = stderrBuf
Expand Down

0 comments on commit e718a13

Please sign in to comment.