Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exit code log and possible memory shortage warning log for Restic command failure #6459

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Jul 4, 2023

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #6001

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2023

Codecov Report

Merging #6459 (d7f1ea4) into main (84eca51) will increase coverage by 1.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #6459      +/-   ##
==========================================
+ Coverage   59.14%   60.18%   +1.04%     
==========================================
  Files         229      229              
  Lines       24184    24217      +33     
==========================================
+ Hits        14303    14575     +272     
+ Misses       8880     8634     -246     
- Partials     1001     1008       +7     
Impacted Files Coverage Δ
pkg/restic/exec_commands.go 15.05% <0.00%> (-0.17%) ⬇️

... and 7 files with indirect coverage changes

@blackpiglet blackpiglet marked this pull request as ready for review July 5, 2023 00:17
@github-actions github-actions bot requested review from Lyndon-Li and sseago July 5, 2023 00:17
@Lyndon-Li Lyndon-Li merged commit 7deae4c into vmware-tanzu:main Jul 7, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need a better way to trace internal process killed by resource limitation
4 participants