Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix backup_controller when credentials to volume snapshot location sh… #6653

Merged

Conversation

yanggangtony
Copy link
Contributor

@yanggangtony yanggangtony commented Aug 15, 2023

Thank you for contributing to Velero!

Please add a summary of your change

for _, location := range providerLocations {
		err = volume.UpdateVolumeSnapshotLocationWithCredentialConfig(location, b.credentialFileStore)
		if err != nil {
			errors = append(errors, fmt.Sprintf("error adding credentials to volume snapshot location named %s: %v", location.Name, err))
			continue
		}
	}

when errors is not nil , should return it .

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@yanggangtony
Copy link
Contributor Author

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #6653 (46ef54e) into main (411bd54) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #6653      +/-   ##
==========================================
- Coverage   60.31%   60.31%   -0.01%     
==========================================
  Files         242      242              
  Lines       25924    25927       +3     
==========================================
  Hits        15637    15637              
- Misses       9186     9188       +2     
- Partials     1101     1102       +1     
Files Changed Coverage Δ
pkg/controller/backup_controller.go 60.96% <0.00%> (-0.29%) ⬇️

@blackpiglet blackpiglet added kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes and removed kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes labels Aug 16, 2023
@yanggangtony
Copy link
Contributor Author

Two maintainer has approved.
Is these need a another maintainer to be merged?

@blackpiglet
Copy link
Contributor

If this is not an urgent issue, I prefer to wait for the v1.12 release cut and RC.1, then we can merge this one to the main branch.

@yanggangtony
Copy link
Contributor Author

OK , not in hurry.

@blackpiglet blackpiglet merged commit a62f2fa into vmware-tanzu:main Aug 21, 2023
24 of 28 checks passed
@yanggangtony yanggangtony deleted the fix-backup-controller-err-check branch August 21, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants