Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource modifiers e2e case #6659

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

qiuming-best
Copy link
Contributor

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@qiuming-best qiuming-best added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Aug 16, 2023
@qiuming-best qiuming-best changed the title Fix resource modifiers e2e case [WIP]Fix resource modifiers e2e case Aug 16, 2023
@qiuming-best
Copy link
Contributor Author

qiuming-best commented Aug 16, 2023

Test still failed with an error, I'll figure it out

time="2023-08-16T03:42:17Z" level=error msg="error restoring resource-modifiers-90576967: Deployment in version \"v1\" cannot be handled as a Deployment: json: cannot unmarshal string into Go struct field DeploymentSpec.spec.replicas of type int32" logSource="pkg/restore/restore.go:1516" restore=velero/restore-resource-modifiers-90576967

when I using the latest code to build the velero container image, the error has gone

image

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #6659 (3f05a7d) into main (e753a08) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6659   +/-   ##
=======================================
  Coverage   60.36%   60.36%           
=======================================
  Files         242      242           
  Lines       25968    25968           
=======================================
  Hits        15676    15676           
  Misses       9190     9190           
  Partials     1102     1102           

@qiuming-best qiuming-best marked this pull request as draft August 16, 2023 03:56
@qiuming-best qiuming-best changed the title [WIP]Fix resource modifiers e2e case Fix resource modifiers e2e case Aug 16, 2023
@qiuming-best qiuming-best marked this pull request as ready for review August 16, 2023 07:09
@danfengliu danfengliu self-requested a review August 16, 2023 07:13
@blackpiglet blackpiglet merged commit dd07a08 into vmware-tanzu:main Aug 16, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-e2e-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants