Make pkg/install/Deployment podTemplateOptions bool functions accept bool param

[kaovilai]

Signed-off-by: Tiger Kaovilai [email protected]

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #7379

Please indicate you've done the following:

• Accepted the DCO. Commits without the DCO will delay acceptance.
• Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
• Updated the corresponding documentation in site/content/docs/main.

[kaovilai]

/kind changelog-not-required

[codecov]

Codecov Report

Attention: Patch coverage is 26.66667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 58.82%. Comparing base (c827fd0) to head (bd2008c).
Report is 28 commits behind head on main.

Files	Patch %	Lines
pkg/install/deployment.go	40.00%	6 Missing ⚠️
pkg/install/resources.go	0.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7942      +/-   ##
==========================================
+ Coverage   58.79%   58.82%   +0.02%     
==========================================
  Files         345      346       +1     
  Lines       28766    28901     +135     
==========================================
+ Hits        16914    17002      +88     
- Misses      10423    10467      +44     
- Partials     1429     1432       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blackpiglet]

IMO, this doesn't make a difference from the original functions.
We can set the --restore-only as false by not calling the WithRestoreOnly() function.

[kaovilai]

@blackpiglet the alternative would be to make podTemplateOption into PodTemplateOption so that i can form dynamically an array of []PodTemplateOption functions outside of this package.

[kaovilai]

for context this is for external consumption of these functions

See: #7379 (comment)

WIthout this Bool func that accepts a param, or alternatively exporting the type, I cannot store these podTemplateOption functions in a slice to pass to install.Deployment(slice...) outside of the install package.

[blackpiglet]

for context this is for external consumption of these functions

See: #7379 (comment)

WIthout this Bool func that accepts a param, or alternatively exporting the type, I cannot store these podTemplateOption functions in a slice to pass to install.Deployment(slice...) outside of the install package.

I see. I suggest refactoring those existing functions to suit your scenario instead of keeping the old and the new ones together.