Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whether the volume's source is PVC before fetching its PV. #7967

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Jul 3, 2024

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #7929

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes missing coverage. Please review.

Project coverage is 58.83%. Comparing base (28d64c2) to head (d89a9f7).

Files Patch % Lines
internal/volumehelper/volume_policy_helper.go 46.15% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7967   +/-   ##
=======================================
  Coverage   58.83%   58.83%           
=======================================
  Files         345      345           
  Lines       28795    28798    +3     
=======================================
+ Hits        16941    16944    +3     
  Misses      10425    10425           
  Partials     1429     1429           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blackpiglet blackpiglet marked this pull request as ready for review July 3, 2024 02:45
@ywk253100 ywk253100 merged commit 71de94b into vmware-tanzu:main Jul 3, 2024
67 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.14.0 Backup error when emptyDir pod volumes are attached
3 participants