Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CherryPick][1.13]Merge pull request #7983 from anshulahuja98/snapshotsync #8005

Merged

Conversation

anshulahuja98
Copy link
Collaborator

@anshulahuja98 anshulahuja98 commented Jul 12, 2024

Reset VolumeSnapshotRef in Backup Sync Flow

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #7978

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 62.02%. Comparing base (5158490) to head (f552c92).

Files Patch % Lines
pkg/controller/backup_sync_controller.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.13    #8005      +/-   ##
================================================
+ Coverage         61.66%   62.02%   +0.35%     
================================================
  Files               262      262              
  Lines             28457    22435    -6022     
================================================
- Hits              17548    13915    -3633     
+ Misses             9670     7281    -2389     
  Partials           1239     1239              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blackpiglet blackpiglet added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Jul 12, 2024
@blackpiglet
Copy link
Contributor

One comment.
It seems we should use this commit 4a6a362 instead of the merge commit.

@anshulahuja98
Copy link
Collaborator Author

Ah ohkay, will fix it in some time @blackpiglet

@anshulahuja98
Copy link
Collaborator Author

Fixed both PRs, @blackpiglet

@anshulahuja98 anshulahuja98 merged commit 89be8e0 into vmware-tanzu:release-1.13 Jul 12, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants