Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repository maintenance job configuration design. #8009

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Jul 12, 2024

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)
Design for #7758

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@blackpiglet blackpiglet added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Jul 12, 2024
@github-actions github-actions bot added the Area/Design Design Documents label Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.82%. Comparing base (84feddb) to head (d72f857).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8009   +/-   ##
=======================================
  Coverage   58.82%   58.82%           
=======================================
  Files         346      346           
  Lines       28892    28892           
=======================================
  Hits        16995    16995           
  Misses      10468    10468           
  Partials     1429     1429           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blackpiglet
Copy link
Contributor Author

Change the way to get the new ConfigMap from name to label.

design/repo_maintenance_job_config.md Outdated Show resolved Hide resolved
design/repo_maintenance_job_config.md Show resolved Hide resolved
design/repo_maintenance_job_config.md Outdated Show resolved Hide resolved
design/repo_maintenance_job_config.md Outdated Show resolved Hide resolved
design/repo_maintenance_job_config.md Outdated Show resolved Hide resolved
design/repo_maintenance_job_config.md Outdated Show resolved Hide resolved
design/repo_maintenance_job_config.md Outdated Show resolved Hide resolved
design/repo_maintenance_job_config.md Show resolved Hide resolved
design/repo_maintenance_job_config.md Outdated Show resolved Hide resolved
design/repo_maintenance_job_config.md Outdated Show resolved Hide resolved
design/repo_maintenance_job_config.md Outdated Show resolved Hide resolved
design/repo_maintenance_job_config.md Show resolved Hide resolved
design/repo_maintenance_job_config.md Outdated Show resolved Hide resolved
design/repo_maintenance_job_config.md Show resolved Hide resolved
design/repo_maintenance_job_config.md Outdated Show resolved Hide resolved
design/repo_maintenance_job_config.md Show resolved Hide resolved
Lyndon-Li
Lyndon-Li previously approved these changes Jul 22, 2024
@blackpiglet blackpiglet merged commit 442cc76 into vmware-tanzu:main Jul 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/Design Design Documents has-unit-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants