Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse existing plugin manager for get/put volume info #8012

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

sseago
Copy link
Collaborator

@sseago sseago commented Jul 12, 2024

Thank you for contributing to Velero!

Please add a summary of your change

Reuse existing plugin manager for get/put volume info. backup.FinalizeBackup was initializing its own plugin manager in getVolumeInfos but cleaning up too early, causing a new plugin process to be initialized in putVolumeInfos which was never getting cleaned up.

This PR changes the workflow to pass in the already-initialized plugin manager from the backup finalizer controller, since there's no need to have a separate one for get/put volume info.

Does your change fix a particular issue?

Fixes #7925

Please indicate you've done the following:

  • [x ] Accepted the DCO. Commits without the DCO will delay acceptance.
  • [x ] Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • [x ] Updated the corresponding documentation in site/content/docs/main.

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 58.82%. Comparing base (3bd8a7d) to head (dc286a3).

Files Patch % Lines
pkg/backup/backup.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8012      +/-   ##
==========================================
- Coverage   58.82%   58.82%   -0.01%     
==========================================
  Files         346      346              
  Lines       28901    28891      -10     
==========================================
- Hits        17002    16996       -6     
+ Misses      10467    10465       -2     
+ Partials     1432     1430       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blackpiglet blackpiglet merged commit 7f9fbab into vmware-tanzu:main Jul 15, 2024
66 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.14.0+: Memory leaks on backups jobs (CSI backups + cloud plugin)
4 participants