Make PVPatchMaximumDuration timeout configurable #8021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8021 +/- ##
=======================================
Coverage 58.82% 58.82%
=======================================
Files 346 346
Lines 28886 28889 +3
=======================================
+ Hits 16993 16995 +2
- Misses 10464 10465 +1
Partials 1429 1429 ☔ View full report in Codecov by Sentry. |
|
@shubham-pampattiwar We discussed this today, we suggest to use the existing |
shubham-pampattiwar
force-pushed
the
expose-pv-patch-max-timeout
branch
from
92388ff
to
ef6d3ab
Compare
|
@Lyndon-Li makes sense, I have updated the PR, PTAL! |
shubham-pampattiwar
changed the title
shubham-pampattiwar
force-pushed
the
expose-pv-patch-max-timeout
branch
from
ef6d3ab
to
671985c
Compare
Lyndon-Li
reviewed
Jul 19, 2024
Signed-off-by: Shubham Pampattiwar <[email protected]> remove debug log Signed-off-by: Shubham Pampattiwar <[email protected]> use resource timeout server arg Signed-off-by: Shubham Pampattiwar <[email protected]> add changelog Signed-off-by: Shubham Pampattiwar <[email protected]> remove hardcoded PVPatchMaximumtimeout const usagDe Signed-off-by: Shubham Pampattiwar <[email protected]>
shubham-pampattiwar
force-pushed
the
expose-pv-patch-max-timeout
branch
from
671985c
to
fd6c747
Compare
Lyndon-Li
approved these changes
Jul 22, 2024
blackpiglet
approved these changes
Jul 22, 2024
|
@shubham-pampattiwar Please help to make the cherry-pick. Thanks. |
|
@Lyndon-Li CP: #8035 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.