Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testifylint: enable more rules #8024

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Jul 17, 2024

Please add a summary of your change

testifylint: enable more rules

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@mmorel-35
Copy link
Contributor Author

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Jul 17, 2024
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.82%. Comparing base (c69f47d) to head (2265c73).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8024   +/-   ##
=======================================
  Coverage   58.82%   58.82%           
=======================================
  Files         346      346           
  Lines       28886    28886           
=======================================
  Hits        16993    16993           
  Misses      10464    10464           
  Partials     1429     1429           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmorel-35 mmorel-35 force-pushed the testifylint/more-rules branch 2 times, most recently from 1256224 to 0323b7d Compare July 17, 2024 08:08
Signed-off-by: Matthieu MOREL <[email protected]>
@blackpiglet blackpiglet requested a review from sseago July 18, 2024 02:32
@sseago sseago merged commit c8baaa9 into vmware-tanzu:main Jul 18, 2024
66 checks passed
@mmorel-35 mmorel-35 deleted the testifylint/more-rules branch July 18, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-unit-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants