-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use labels instead of regex to filter E2E test cases. #8038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackpiglet
added
the
kind/changelog-not-required
PR does not require a user changelog. Often for docs, website, or build changes
label
Jul 23, 2024
blackpiglet
force-pushed
the
7959_fix
branch
2 times, most recently
from
July 23, 2024 06:47
d9db13f
to
534922e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8038 +/- ##
=======================================
Coverage 58.79% 58.79%
=======================================
Files 349 349
Lines 29063 29063
=======================================
Hits 17089 17089
Misses 10542 10542
Partials 1432 1432 ☔ View full report in Codecov by Sentry. |
blackpiglet
force-pushed
the
7959_fix
branch
3 times, most recently
from
July 23, 2024 09:25
f222c22
to
dc1e86f
Compare
kaovilai
reviewed
Jul 23, 2024
sseago
reviewed
Jul 23, 2024
Signed-off-by: Xun Jiang <[email protected]>
kaovilai
reviewed
Jul 24, 2024
Signed-off-by: Xun Jiang <[email protected]>
Lyndon-Li
approved these changes
Jul 25, 2024
shubham-pampattiwar
approved these changes
Jul 25, 2024
sseago
approved these changes
Jul 25, 2024
kaovilai
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
has-e2e-2tests
kind/changelog-not-required
PR does not require a user changelog. Often for docs, website, or build changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #7958
Fixes #7959
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.