Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-1.14: Allow make local to work without docker in path #8057

Merged

Conversation

kaovilai
Copy link
Contributor

Signed-off-by: Tiger Kaovilai [email protected]

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #8055 (issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@kaovilai
Copy link
Contributor Author

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Jul 29, 2024
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.77%. Comparing base (8afe3ce) to head (7f7b763).
Report is 2 commits behind head on release-1.14.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.14    #8057   +/-   ##
=============================================
  Coverage         58.77%   58.77%           
=============================================
  Files               346      346           
  Lines             28824    28824           
=============================================
  Hits              16940    16940           
  Misses            10455    10455           
  Partials           1429     1429           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@4censord
Copy link

I can confirm that this fixes the issue.

Copy link
Contributor

@reasonerjt reasonerjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@reasonerjt reasonerjt merged commit 0057a89 into vmware-tanzu:release-1.14 Aug 28, 2024
66 checks passed
@kaovilai
Copy link
Contributor Author

kaovilai commented Oct 1, 2024

cherrypicks #8056

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants