Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data mover micro service node agent resume #8085

Merged

Conversation

Lyndon-Li
Copy link
Contributor

@Lyndon-Li Lyndon-Li commented Aug 6, 2024

According to design #7576, after node-agent restarts, if a DU/DD is in InProgress status, re-capture the data mover ms pod and continue the execution

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 76.68394% with 45 lines in your changes missing coverage. Please review.

Project coverage is 58.98%. Comparing base (dd3d05b) to head (04db3ba).
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/controller/data_download_controller.go 80.23% 14 Missing and 3 partials ⚠️
pkg/controller/data_upload_controller.go 87.77% 8 Missing and 3 partials ⚠️
pkg/cmd/server/server.go 0.00% 10 Missing ⚠️
pkg/cmd/cli/nodeagent/server.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8085      +/-   ##
==========================================
+ Coverage   58.77%   58.98%   +0.21%     
==========================================
  Files         358      358              
  Lines       30070    30083      +13     
==========================================
+ Hits        17674    17745      +71     
+ Misses      10949    10901      -48     
+ Partials     1447     1437      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lyndon-Li Lyndon-Li force-pushed the data-mover-ms-node-agent-resume branch from c6e9735 to 75cf40e Compare August 6, 2024 08:12
@Lyndon-Li Lyndon-Li force-pushed the data-mover-ms-node-agent-resume branch from 75cf40e to a523d10 Compare August 6, 2024 08:26
@Lyndon-Li Lyndon-Li marked this pull request as ready for review August 8, 2024 03:27
pkg/builder/data_download_builder.go Outdated Show resolved Hide resolved
pkg/builder/data_upload_builder.go Outdated Show resolved Hide resolved
pkg/cmd/cli/nodeagent/server.go Outdated Show resolved Hide resolved
pkg/controller/data_download_controller.go Outdated Show resolved Hide resolved
pkg/controller/data_upload_controller.go Outdated Show resolved Hide resolved
@Lyndon-Li Lyndon-Li force-pushed the data-mover-ms-node-agent-resume branch from a21a95f to 04db3ba Compare August 12, 2024 02:46
@Lyndon-Li Lyndon-Li merged commit 07c03a8 into vmware-tanzu:main Aug 13, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants