Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the pkg/generated directory. #8114

Merged

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Aug 14, 2024

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #6190

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@blackpiglet blackpiglet self-assigned this Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.03%. Comparing base (07c03a8) to head (4ffc6d1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8114   +/-   ##
=======================================
  Coverage   59.03%   59.03%           
=======================================
  Files         358      358           
  Lines       30141    30141           
=======================================
  Hits        17795    17795           
  Misses      10907    10907           
  Partials     1439     1439           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blackpiglet blackpiglet marked this pull request as ready for review August 14, 2024 02:57
@shubham-pampattiwar shubham-pampattiwar merged commit 6c3988e into vmware-tanzu:main Aug 14, 2024
48 checks passed
@mateusoliveira43
Copy link
Contributor

why was my PR #7627 overlooked? I had it linked with the same issue and it was ready for merge for 2 months

@blackpiglet
Copy link
Contributor Author

@mateusoliveira43
Sorry, I didn't realize there was already an in-progress PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate how to remove the generated legacy client-go code.
5 participants