-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass Velero server command args to the plugins #8166
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8166 +/- ##
==========================================
+ Coverage 59.07% 59.10% +0.03%
==========================================
Files 364 365 +1
Lines 30307 30336 +29
==========================================
+ Hits 17904 17931 +27
- Misses 10960 10962 +2
Partials 1443 1443 ☔ View full report in Codecov by Sentry. |
c52baf9
to
00c027b
Compare
pkg/cmd/server/config/priority.go
Outdated
@@ -14,7 +14,7 @@ See the License for the specific language governing permissions and | |||
limitations under the License. | |||
*/ | |||
|
|||
package restore | |||
package config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The priority.go
doesn't depend on any package.
IMO, this file is better placed in the pkg/util
directory.
pkg/cmd/server/config/config.go
Outdated
// files will be written to | ||
defaultCredentialsDirectory = "/tmp/credentials" | ||
|
||
ControllerBackup = "backup" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should consider decoupling the pkg/cmd
and pkg/controller
packages.
Maybe adding a pkg/types
package to hold the common-used constant variables and structures can help to avoid packages importing each other.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@sseago @shubham-pampattiwar Could you also take a look at this PR? |
Pass Velero server command args to the plugins Fixes vmware-tanzu#7806 Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
00c027b
to
dc6eeaf
Compare
@blackpiglet @shubham-pampattiwar Please take a look at this PR again. |
Pass Velero server command args to the plugins
Fixes #7806
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.