-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure pkg/install do not import pkg/plugin/framework #8180
Ensure pkg/install do not import pkg/plugin/framework #8180
Conversation
/kind changelog-not-required |
c0635ae
to
30a9224
Compare
30a9224
to
55d1b0b
Compare
looks like 8145 ultimately failed to pass this test after some force pushes later. moving back to draft. |
4dd01bf
to
21b6dac
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8180 +/- ##
==========================================
- Coverage 59.21% 59.19% -0.03%
==========================================
Files 367 367
Lines 30708 30775 +67
==========================================
+ Hits 18184 18216 +32
- Misses 11069 11102 +33
- Partials 1455 1457 +2 ☔ View full report in Codecov by Sentry. |
21b6dac
to
cb1ea3b
Compare
This PR becomes unnecessary if #8208 merges. |
Signed-off-by: Tiger Kaovilai <[email protected]>
Signed-off-by: Tiger Kaovilai <[email protected]>
Signed-off-by: Tiger Kaovilai <[email protected]> Signed-off-by: Tiger Kaovilai <[email protected]>
95ac94d
to
27aa8e5
Compare
Closing this one as #8208 is merged |
Signed-off-by: Tiger Kaovilai [email protected]
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #8157 (hopefully forever)
Rebased after #8145. This passes with #8145 and moving images.go away from /internal/velero which contain imports to pkg/plugin/framework which imports many cloud sdks. (created #8207)
This PR can be replaced or supplemented by #8208
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.