Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update design doc and site docs to reflect ItemBlock implementation #8218

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

sseago
Copy link
Collaborator

@sseago sseago commented Sep 13, 2024

Update design doc and site docs to reflect ItemBlock implementation

Note that for the existing velero plugin types, the site docs do not directly include field-by-field specifications. Instead, the user is linked to the velero-plugin-example repo for examples of each plugin type. Consistent with that, vmware-tanzu/velero-plugin-example#74 should be considered a companion PR to this one, which makes some minor updates to site docs and modifies the feature design doc to reflect changes made during phase 1 implementation.

Please add a summary of your change

Note that for the existing velero plugin types, the site docs do not directly include field-by-field specifications. Instead, the user is linked to the velero-plugin-example repo for examples of each plugin type. Consistent with that, vmware-tanzu/velero-plugin-example#74 should be considered a companion PR to this one, which makes some minor updates to site docs and modifies the feature design doc to reflect changes made during phase 1 implementation.

Does your change fix a particular issue?

Fixes #7900

Please indicate you've done the following:

@sseago
Copy link
Collaborator Author

sseago commented Sep 13, 2024

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Sep 13, 2024
As with other plugin types, the information on how to implement
an IBA plugin will be in the velero-plugin-example repo.

Signed-off-by: Scott Seago <[email protected]>
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.15%. Comparing base (3f9c2dc) to head (e6fb4ba).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8218   +/-   ##
=======================================
  Coverage   59.15%   59.15%           
=======================================
  Files         367      367           
  Lines       30777    30777           
=======================================
  Hits        18206    18206           
  Misses      11113    11113           
  Partials     1458     1458           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shubham-pampattiwar shubham-pampattiwar merged commit 0b74a73 into vmware-tanzu:main Sep 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/Design Design Documents Documentation kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Phase 1 implementation for backup performance improvements
3 participants