Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additionalPrinterColumns for backups.velero.io crd #8221

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

df-cgdm
Copy link

@df-cgdm df-cgdm commented Sep 16, 2024

Show main status properties when doing a "kubectl get backups.velero.io" or using any kube manager UI.

Show main status properties when doing a "kubectl get backups.velero.io" or using any kube manager UI.

Signed-off-by: df-cgdm <[email protected]>
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.15%. Comparing base (3f9c2dc) to head (3c04d0e).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8221   +/-   ##
=======================================
  Coverage   59.15%   59.15%           
=======================================
  Files         367      367           
  Lines       30777    30777           
=======================================
  Hits        18206    18206           
  Misses      11113    11113           
  Partials     1458     1458           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blackpiglet blackpiglet added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Sep 18, 2024
Signed-off-by: df-cgdm <[email protected]>
@reasonerjt
Copy link
Contributor

reasonerjt commented Sep 23, 2024

Thanks for the PR but ATM I don't think this is very necessary.

Would you mind opening an issue to propose this change? If there are enough thumb-ups we can re-consider making this change.

Copy link
Contributor

@reasonerjt reasonerjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to my previous comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-changelog kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants