Remove multiple single quotes from Velero backup.status.validationErrors field

[shubham-pampattiwar]

Thank you for contributing to Velero!

Please add a summary of your change

Remove multiple single quotes from error message

Please indicate you've done the following:

• Accepted the DCO. Commits without the DCO will delay acceptance.
• Created a changelog file (make new-changelog) or comment /kind changelog-not-required on this PR.
• Updated the corresponding documentation in site/content/docs/main.

[reasonerjt]

@shubham-pampattiwar
Thanks but could you clarify why we wanna remove the single quote?

[shubham-pampattiwar]

@reasonerjt Validation error has extra quotes around BSL name:

status:
  expiration: "2024-10-27T17:54:55Z"
  formatVersion: 1.1.0
  phase: FailedValidation
  validationErrors:
  - 'an existing backup storage location wasn''t specified at backup creation time
    and the default ''sample-dpa-11'' wasn''t found. Please address this issue (see
    `velero backup-location -h` for options) and create a new backup. Error: BackupStorageLocation.velero.io
    "sample-dpa-11" not found'
  version: 1

With this change the extra quotes are removed:

status:
  expiration: "2024-10-27T18:20:38Z"
  formatVersion: 1.1.0
  phase: FailedValidation
  validationErrors:
  - 'an existing backup storage location wasn''t specified at backup creation time
    and the default sample-dpa-11 wasn''t found. Please address this issue (see `velero
    backup-location -h` for options) and create a new backup. Error: BackupStorageLocation.velero.io
    "sample-dpa-11" not found'

[kaovilai]

wasn''t still looks bad

location wasn''t specified

[shubham-pampattiwar]

wasn''t still looks bad

location wasn''t specified

Updated the error message:

validationErrors:
  - 'an existing backup storage location was not specified at backup creation time
    and the default sample-dpa-11 was not found. Please address this issue (see `velero
    backup-location -h` for options) and create a new backup. Error: BackupStorageLocation.velero.io
    "sample-dpa-11" not found'

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@11f771f). Learn more about missing BASE report.
Report is 8 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8245   +/-   ##
=======================================
  Coverage        ?   59.21%           
=======================================
  Files           ?      367           
  Lines           ?    30841           
  Branches        ?        0           
=======================================
  Hits            ?    18262           
  Misses          ?    11119           
  Partials        ?     1460           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.