adding context to allow timeout/cancellation of http request #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # govcd/edgegateway_test.go # govcd/filter_helpers.go # govcd/vdc.go
|
I assume this should go on a /v3 since it changes all of the method signatures. I just wanted to put this up to communicate what I was needing for my project. I'll squash this onto my fork so if anyone wants to cherry-pick it later it will be easier to pull back upstream. |
|
@jakecoffman will you continue to work on this PR? |
|
@lelvisl no, sorry too much work for me to keep it updated to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue: #362
I switched out the two
http.NewRequestcalls withhttp.NewRequestWithContextand then just started passingcontext.Contextdown through all the functions.This will allow users to set timeouts on the http operations or cancel them manually such as ctrl-c on a command line or graceful server shutdown.